Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support string and symbol for os resource #299

Merged
merged 1 commit into from
Dec 7, 2015
Merged

Conversation

chris-rock
Copy link
Contributor

fixes #227

@chris-rock chris-rock added the Type: Enhancement Improves an existing feature label Dec 7, 2015
@srenatus
Copy link
Contributor

srenatus commented Dec 7, 2015

Not sure if I'm missing something, but my test (cd test/integation; kitchen test default-ubuntu-1404) fails:

[...]
       Finished setting up <default-ubuntu-1404> (0m0.00s).
-----> Verifying <default-ubuntu-1404>...
"You are currently running on OS family: ubuntu, OS release: 14.04"
.................................................................................[DEPRECATION] `linux_kernel_parameter(parameter)` is deprecated.  Please use `kernel_parameter(parameter)` instead.
..F..............[DEPRECATION] `belong_to_group` is deprecated.  Please use `its(:groups) { should include('root') }` instead.
........

Failures:

  1)  should eq "ubuntu"
     Failure/Error: DEFAULT_FAILURE_NOTIFIER = lambda { |failure, _opts| raise failure }

       expected: "ubuntu"
            got: nil

       (compared using ==)
     # ./test/integration/default/os_spec.rb:12:in `block (2 levels) in load'

Finished in 0.42298 seconds (files took 3 minutes 14.9 seconds to load)
106 examples, 1 failure

Failed examples:

rspec  #  should eq "ubuntu"

@srenatus
Copy link
Contributor

srenatus commented Dec 7, 2015

Works in inspec shell though. Confusing. I guess my kitchen test run is not picking up the changes in inspec...?

srenatus added a commit that referenced this pull request Dec 7, 2015
support string and symbol for os resource
@srenatus srenatus merged commit bf15c05 into master Dec 7, 2015
@srenatus srenatus deleted the chris-rock/os-resource branch December 7, 2015 11:23
@chris-rock chris-rock removed the Type: Enhancement Improves an existing feature label Dec 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OS resource with string and symbol support
2 participants