Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Integration Tests #314

Merged
merged 4 commits into from
Jan 4, 2016
Merged

Update Integration Tests #314

merged 4 commits into from
Jan 4, 2016

Conversation

chris-rock
Copy link
Contributor

  • add windows support for yml, csv and ini integration tests
  • add ec2 example

@@ -106,4 +105,9 @@
its('type') { should eq :directory }
end

elsif os.windows?
describe file('C:\\Windows') do
it { should exist }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adds a test for #288

@chris-rock chris-rock added the Type: Enhancement Improves an existing feature label Dec 11, 2015
@chris-rock chris-rock changed the title update integration tests WIP: update integration tests Dec 14, 2015
@chris-rock chris-rock changed the title WIP: update integration tests WIP: Update Integration Tests Dec 14, 2015
@chris-rock
Copy link
Contributor Author

TODO: Add integration test for security policy, see #321

interface: dns

transport:
ssh_key: /Users/chartmann/Development/key/aws_chartmann.pem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix this in the next MR.

@arlimus arlimus force-pushed the chris-rock/integration-tests branch from 79f776f to f7efd93 Compare January 3, 2016 08:23
@chris-rock chris-rock changed the title WIP: Update Integration Tests Update Integration Tests Jan 4, 2016
@arlimus arlimus force-pushed the chris-rock/integration-tests branch from f7efd93 to 5c5ed10 Compare January 4, 2016 02:50
@arlimus
Copy link
Contributor

arlimus commented Jan 4, 2016

Fantastic new integration tests, kudos @chris-rock 👍

arlimus added a commit that referenced this pull request Jan 4, 2016
@arlimus arlimus merged commit 7bba1af into master Jan 4, 2016
@arlimus arlimus deleted the chris-rock/integration-tests branch January 4, 2016 03:00
@chris-rock chris-rock added this to the 0.9.8 milestone Jan 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants