Support old "supports" field in metadata #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -74,6 +71,21 @@ def is_supported(os, entry) | |||
| name_ok && family_ok && release_ok | |||
| end | |||
|
|
|||
| def support_fields(entry) | |||
| @logger.warn("logging") | |||
There was a problem hiding this comment.
one littel debugging call left ^^
current compliance-profiles still have ```yaml supports: - linux ``` and we might want to be a little backwards compatible, too.
arlimus
force-pushed
the
sr/backwards-compatible-supports
branch
from
6be5795
to
3ce8cd7
Compare
|
Thank you @srenatus , this fixes our migration issues. |
arlimus
added a commit
that referenced
this pull request
Jan 5, 2016
WIP support old "supports" field in metadata
|
Small clarification: We haven't had an official handling on |
|
@arlimus thanks for fixing that up before the merge. :) |
chris-rock
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current compliance-profiles still have
and we might want to be a little backwards compatible, too.
WIP because tests are missing