fix reading profiles bug #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For reading the profiles metadata, we're using the train mock backend through Inspec::Runner. The new `supports` feature never agrees with the mock backend. Now, it we figure out if this is a mock class and then just say that it supports whatever we're asking for. Tl;dr: there's probably a more beautiful solution to this. Added a test case, but it fails -- while the command line interface works fine.
|
Ok, this breaks many of our other tests... because we're setting up a "mock-ish" ubuntu backend (for example), that is mock enough to trigger the |
Merged
chris-rock
force-pushed
the
sr/fix-profiles
branch
from
173feaa
to
177c30a
Compare
chris-rock
force-pushed
the
sr/fix-profiles
branch
from
177c30a
to
a1ddbe4
Compare
|
I extended the PR to make the support check optional. |
|
this fix leaves #354 |
|
Looks great, thank you both for the fix! 👍 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reading the profiles metadata, we're using the train mock backend
through Inspec::Runner. The new
supportsfeature never agrees with themock backend.
Now, it we figure out if this is a mock class and then just say that it
supports whatever we're asking for.
Tl;dr: there's probably a more beautiful solution to this.
Added a test case, but it fails -- while the command line interface
works fine.
Fixes #351.