Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add profile tests (non-legacy) #375

Merged
merged 1 commit into from
Jan 20, 2016
Merged

add profile tests (non-legacy) #375

merged 1 commit into from
Jan 20, 2016

Conversation

arlimus
Copy link
Contributor

@arlimus arlimus commented Jan 20, 2016

we missed these last time around when rspec and our tests were clashing. fixed and updated.

@@ -11,13 +11,11 @@ module DirsHelper
# TODO: remove `test` support for InSpec 1.0
class ProfileDir
def handles?(paths)
return true if paths.include?('inspec.yml')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i.e. we don't need controls or test folder, just finding inspec.yml is enough.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chris-rock
Copy link
Contributor

Thanks @arlimus for this improvement

chris-rock added a commit that referenced this pull request Jan 20, 2016
add profile tests (non-legacy)
@chris-rock chris-rock merged commit 95c22b8 into master Jan 20, 2016
@chris-rock chris-rock deleted the dr/profile-tests branch January 20, 2016 22:31
@chris-rock chris-rock added the Type: Enhancement Improves an existing feature label Jan 22, 2016
@chris-rock chris-rock added this to the 0.9.10 milestone Jan 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants