resource/postgres_session: add integration tests, change error handling #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
force-pushed
the
sr/fix-postgres-session
branch
from
849136f
to
1034323
Compare
|
The rspec stuff is really really old :-) do not use this anymore |
|
@srenatus could you please rebase to master? |
srenatus
force-pushed
the
sr/fix-postgres-session
branch
from
1034323
to
c6aae58
Compare
|
Done. :) |
srenatus
force-pushed
the
sr/fix-postgres-session
branch
from
c6aae58
to
5b02dd0
Compare
this makes it work (tested with default-ubuntu-1404), but doesn't improve the error handling (i.e., the skip_resource doesn't really prevent the failure)
chris-rock
force-pushed
the
sr/fix-postgres-session
branch
from
5b02dd0
to
56f22a1
Compare
|
Thanks for updating the resource and adding integration tests. Great work @srenatus |
chris-rock
added a commit
that referenced
this pull request
Jan 25, 2016
resource/postgres_session: add integration tests, change error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the included integration test work (tested with default-ubuntu-1404), but doesn't improve the error handling (i.e., the skip_resource doesn't really prevent the failure).
I do not fully understand what the idea of this
RSpec.__send__('describe', l, &block)line was. In any way, we should (mentally) flag this resource for needing revision.Addresses #302.