Improve apache resource #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| param = @params[name.to_s] | ||
| return nil if param.nil? | ||
| # extract first value if we have only one value in array | ||
| return param[0] if param.length == 1 |
There was a problem hiding this comment.
as proposed by @srenatus we should not be smart here, lets leave this for the matcher
chris-rock
force-pushed
the
chris-rock/apache
branch
from
b9c450c
to
b702942
Compare
arlimus
force-pushed
the
chris-rock/apache
branch
from
359e4dc
to
0f14ebb
Compare
|
Cheers @chris-rock for kicking this off! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #406.