Use target helpers in Inspec::Profile#from_file #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Phew, so travis-ci has |
current output:
$ inspec check test/unit/mock/profiles/complete-profile.tgz
I, [2016-02-03T10:22:21.377650 #13207] INFO -- : Checking profile in test/unit/mock/profiles/complete-profile.tgz
I, [2016-02-03T10:22:21.377745 #13207] INFO -- : Found 1 rules.
I, [2016-02-03T10:22:21.377771 #13207] INFO -- : Rule definitions OK.
Note that this adds `ref: some/where/in/tarball/file` to the file contents hash; it wasn't there before but it may be useful for error reporting nonetheless.
| # NB if you want to check more than one profile, use one | ||
| # Inspec::Profile#from_file per profile | ||
| m = metadata.first | ||
| @metadata = Metadata.from_ref(m[:ref], m[:content], @profile_id, @logger) |
There was a problem hiding this comment.
imho parse metadata beore adding/parsing tests; if anything fails with metadata, we don't jump into parsing tests
srenatus
changed the title
chris-rock
changed the title
chris-rock
force-pushed
the
sr/fix-408
branch
from
3b6c92f
to
81de512
Compare
|
Thanks @renatus for this great fix |
chris-rock
added a commit
that referenced
this pull request
Feb 4, 2016
Use target helpers in Inspec::Profile#from_file
|
Wait... that order... is... important? ❔ 😕 ❔ Thanks for catching that @chris-rock :) |
|
Needed this for #409 :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: Inspec::Profile was expecting a profile in a filesystem.
After: Inspec::Profile operates on the contents as returned from the target helper
Fixes #408.