update to winrm 1.6.1 command scheme #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Thanks @arlimus |
chris-rock
added a commit
that referenced
this pull request
Feb 9, 2016
update to winrm 1.6.1 command scheme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... + typos + minor
only relevant for unit tests
Also: we should consider either pinning the winrm gem version ourselves or find a different way to depend on it. Simplest solution would be to force train to use winrm 1.6.1+, but then again these errors only occur in our unit tests because of expectations. It's perfectly fine to use winrm 1.6.0 for this as well... ideas?