separate directory resolver from target resolver #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlimus
force-pushed
the
dr/dir-resolver
branch
from
bd51717
to
293b1a4
Compare
srenatus
added a commit
that referenced
this pull request
Feb 10, 2016
start directory resolver cleanup
arlimus
changed the title
arlimus
changed the title
arlimus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our target resolvers are split up into "retrieve that file / url / ..." and "understand what this thing is you are handling and get me inspec code". The division between these has not been clean, they are still sharing their space in the Targets library.
This MR puts our
DirsHelperinto the special position it is in: A collection of resolvers that take a folder structure of any kind (be it local or e.g. inside of a tar-archive) and turns it into raw string'y content.These directory resolvers now register with
DirsHelper. They inherit fromDirsResolverand must provide a method to get relevant filenames from their (virtual/local) folder viaget_files.Directory resolvers themselves haven't changed: they still default to
handles?,get_filenames,get_libraries, andget_metadata. This has been added as a description in code.