Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure permissions of inspec-compliance config.json on store #461

Merged
merged 1 commit into from
Feb 17, 2016

Conversation

srenatus
Copy link
Contributor

The default umask might allow for reading the authentication token by anyone. It will ensure that it's only readable/writable by the user (0600) now.

NB there's no measure to not read a world-writable config.json on get.

@srenatus srenatus added Type: Bug Feature not working as expected Aspect: Security labels Feb 17, 2016
@srenatus
Copy link
Contributor Author

Ah sh... I'll kill that experiment commit.

@chris-rock
Copy link
Contributor

Awesome. Thanks for this fix @srenatus

chris-rock added a commit that referenced this pull request Feb 17, 2016
ensure permissions of inspec-compliance config.json on store
@chris-rock chris-rock merged commit 103dc09 into master Feb 17, 2016
@chris-rock chris-rock deleted the sr/config-permissions branch February 17, 2016 10:11
@chris-rock chris-rock modified the milestone: 0.13.0 Feb 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aspect: Security Type: Bug Feature not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants