fix url target resolution with zip and tar #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does:
|
| .gsub('%owner_name%', owner) | ||
| .gsub('%profile_name%', profile) | ||
| url | ||
| "#{config['server']}/owners/#{owner}/compliance/#{profile}/tar" |
There was a problem hiding this comment.
Thank you @srenatus for this hint: https://github.com/chef/inspec/pull/458/files#diff-e975c4d3a237ff3f9a0f22cc54abab4aR49
Closed
chris-rock
force-pushed
the
dr/fix-targets
branch
2 times, most recently
from
c7d9379
to
98035fa
Compare
The zip command is not always there. (e.g. i dont have it on my box). just use the available zip library
chris-rock
force-pushed
the
dr/fix-targets
branch
from
bfbb242
to
26276ca
Compare
|
Thanks for this fix @arlimus |
chris-rock
added a commit
that referenced
this pull request
Feb 18, 2016
fix url target resolution with zip and tar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes the bug that #458 is targeting
does not yet split out the plugin system for
TargetsandDirsHelpercheers @chris-rock for finding this one!