bugfix: make sure version is always a string #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlimus
force-pushed
the
dr/ensure-strings
branch
2 times, most recently
from
de59a0c
to
41c4d0c
Compare
srenatus
force-pushed
the
dr/ensure-strings
branch
from
41c4d0c
to
1147d30
Compare
srenatus
added a commit
that referenced
this pull request
Feb 22, 2016
bugfix: make sure version is always a string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We tend to be lax on filetypes in ruby, but this may have dire consequences when JSON input is read by something doing diligent type-checking. Make sure it's a string.