force encoding to utf-8 #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arlimus yup, "shouldn't this be in train" was my first thought, too. Merged as the quick-fix workaround it is... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a starting point. In a few (rare or less so) cases, we retrieve data from target machines whose input will be written in a strange or ancient language. It's called non-utf-8 encoding. RSpec doesn't like it (or rather: it's formatter doesn't). Even without that, we should make sure to unify encodings across interfaces.
As a starting point, this only serves to relieve a small problem that is currently blocking me. Let's move this conversation to train later on.