Rename internal File and OS resource classes #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just for simplicity. I expect other users to make the same mistake when using it, so I would rather our tests crash if we have this type of conflict again and prevent it in the first place. Renaming File to FileResource should take care of all important places
|
This is a great simplification for developers. Thanks @arlimus |
chris-rock
added a commit
that referenced
this pull request
Mar 9, 2016
rename File and OS resources
arlimus
changed the title
arlimus
changed the title
arlimus
changed the title
|
I had contemplated doing this but wasn't sure if it would be OK... and thought then maybe we should rename EVERYTHING to be consistent. Such a slippery slope. 😄 Thanks, @arlimus! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #526 by @adamleff . Although it already prevents clashes on the global plane, I still think it's easy enough to accidentally call
Fileinside a new resource and instead of getting::Fileyou get access to inspec's internal resource - which leads to potentially frustrating debugging. So as an additional layer to the MR ^^, we rename these resources and re-expose simpleFilecalls, i.e. detect any problems early on.