Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding named resource registry classes #540

Merged
merged 2 commits into from
Mar 17, 2016

Conversation

adamleff
Copy link
Contributor

This is a cosmetic change to give the anonymous registry classes names to make it a bit clearer where to look when debugging in Pry.

The registry will look more like this:

"apache_conf"=>Inspec::Resource::Registry::ApacheConf,
"apt"=>Inspec::Resource::Registry::Apt,
"ppa"=>Inspec::Resource::Registry::Ppa,
"audit_policy"=>Inspec::Resource::Registry::AuditPolicy,

... instead of this:

"apache_conf"=>#<Class:0x007f991d4a0fc0>,
"apt"=>#<Class:0x007f991d482e58>,
"ppa"=>#<Class:0x007f991d482228>,
"audit_policy"=>#<Class:0x007f991d4799e8>,

@arlimus
Copy link
Contributor

arlimus commented Mar 17, 2016

This is an awesome improvement!! Thank you @adamleff 😄

@arlimus arlimus force-pushed the adamleff/named_registry_classes branch from 35476b7 to ba07ef6 Compare March 17, 2016 11:56
@arlimus arlimus force-pushed the adamleff/named_registry_classes branch 3 times, most recently from 4151c20 to 1b96149 Compare March 17, 2016 12:56
@arlimus
Copy link
Contributor

arlimus commented Mar 17, 2016

After adding a couple of tests, I noticed we'll need one more fix ^^ to get this cleared. Almost there...

@arlimus arlimus force-pushed the adamleff/named_registry_classes branch from 1b96149 to ca5f7b8 Compare March 17, 2016 14:58
arlimus added a commit that referenced this pull request Mar 17, 2016
@arlimus arlimus merged commit ed02356 into master Mar 17, 2016
@arlimus arlimus deleted the adamleff/named_registry_classes branch March 17, 2016 15:06
@arlimus arlimus added the Type: Enhancement Improves an existing feature label Mar 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants