Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspec-compliance: fix upload of profiles #573

Merged
merged 1 commit into from
Mar 23, 2016
Merged

Conversation

srenatus
Copy link
Contributor

Fixes #572.

The bug was a change in Inspec::Profile.archive.

Removed some caveats that seemed to be possible reasons but were not:

  • Use Dir::Tmpname.create when we only need a temp name, not a file.
  • Use binary mode for reading the tarball, because it's binary data.
  • Don't set content-type header twice.

@srenatus srenatus added the Type: Bug Feature not working as expected label Mar 23, 2016
@arlimus
Copy link
Contributor

arlimus commented Mar 23, 2016

Awesome improvements on top of the fix! 👍
Cheers @srenatus

@arlimus arlimus merged commit ca8194c into master Mar 23, 2016
@arlimus arlimus deleted the sr/fix-upload-profiles branch March 23, 2016 15:39
@aaronlippold
Copy link
Collaborator

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Feature not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants