inspec-compliance + Compliance 1.0 #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to ensure that it also works with older versions. This extension does not work with versions pre-1.0 |
| # logs into the server, retrieves a token and stores it locally | ||
| def self.login(server, username, password, insecure) | ||
| # saves the api token supplied by the user | ||
| def self.api_token(server, refresh_token, verify, user, insecure) |
There was a problem hiding this comment.
we should still be able to input username and password
chris-rock
changed the title
| @@ -8,7 +8,8 @@ This extensions offers the following features: | |||
|
|
|||
| To use the CLI, this InSpec add-on adds the following commands: | |||
|
|
|||
| * `$ inspec compliance login user password` - authentication against Chef Compliance | |||
| * `$ inspec compliance api_token server --token TOKEN --user USER` - save the Chef Compliance API token for user | |||
There was a problem hiding this comment.
I think this plugin should offer two methods
- handle the complete oauth flow to retrieve a token. that allows the plugin to get a refresh token as well (requires us to setup a specific client/application for inspec)
- take an api token as input
srenatus
changed the title
chris-rock
changed the title
|
At this point of time, this PR misses a couple of things:
|
|
I add additions to this PRs to address this |
chris-rock
changed the title
|
Thanks @chris-rock for the additions! 👍 Note that when https://github.com/chef/chef-compliance/pull/767 is merged, we should probably (re)introduce another variant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes the necessary adaptations for having inspec's compliance plugin work with compliance 1.0.