Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended gordon_config with more examples #610

Merged
merged 2 commits into from
Apr 4, 2016
Merged

Conversation

alexpop
Copy link
Contributor

@alexpop alexpop commented Apr 4, 2016

Extended the example Inspec resource based on these two questions:

https://discourse.chef.io/t/inspec-profile-library-classes/8044/3
https://discourse.chef.io/t/inspec-use-returned-results-from-one-testcase-in-another-test-case/8079

Making the ruby code a bit more explicit for users with limited ruby/programming background.

end

# Expose all parameters
def method_missing(name)
@params[name.to_s]
return @params[name.to_s]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not need a return in ruby if its the last statement

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the returns for users that are not familiar with ruby and are used to see methods return something.

@chris-rock
Copy link
Contributor

Great addition @alexpop

@chris-rock chris-rock merged commit 4ab190a into master Apr 4, 2016
@chris-rock chris-rock deleted the ap/super_gordon branch April 4, 2016 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants