Add support for suse 11 to service resource #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Systemd.new(inspec, service_ctl) | ||
| elsif %w{suse opensuse}.include?(family) | ||
| version = inspec.os[:release].to_i | ||
| if (%w{ suse opensuse }.include?(family) && version >= 12) |
There was a problem hiding this comment.
I think we can focus on version checking here. No need to test the family again
There was a problem hiding this comment.
@chris-rock giving it another try, let me know.
| Systemd.new(inspec, service_ctl) | ||
| elsif %w{suse opensuse}.include?(family) | ||
| if (inspec.os[:release].to_i >= 12) |
There was a problem hiding this comment.
please use if inspec.os[:release].to_i >= 12 to meet our lint guidelines
|
That addition looks really good now. Also please add |
|
@chris-rock just checked the changes suggested above |
|
Thanks @spuranam for this addition |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address issue 627.