fail on unsupported os/platform #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
force-pushed
the
dr/supports-exits
branch
from
31587ee
to
2a0ccbf
Compare
|
Thanks @arlimus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create consistency with unsupported platform versions (i.e. exit instead of adding
skip xyzto resources).Skipping because of os/platform is intentional from a profile author's standpoint. It should not show up with a list results.
Skipping because of unsupported cases within resources are typically not intential from a profile author's standpoint. Resources may need to be extended, may be inapropriate, or may lack a foundation to run their tests. In all cases
skipis valid.All of ^^ being said, there is still some work to be done on consistency, especially with error reporting in JSON formatters.