Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basename parameter and add tests #701

Merged
merged 1 commit into from
Apr 29, 2016
Merged

Add basename parameter and add tests #701

merged 1 commit into from
Apr 29, 2016

Conversation

alexpop
Copy link
Contributor

@alexpop alexpop commented Apr 29, 2016

Working on the tests for this PR, I've noticed this train error for Windows:

inspec> f=file('c:\Users\vagrant')
ArgumentError: wrong number of arguments (2 for 3)
from /Users/apop/.chefdk/gem/ruby/2.1.0/gems/r-train-0.11.1/lib/train/extras/file_windows.rb:14:in `initialize'

@alexpop alexpop added the Type: Enhancement Improves an existing feature label Apr 29, 2016
@arlimus
Copy link
Contributor

arlimus commented Apr 29, 2016

Great catch, thank you @alexpop !

@arlimus arlimus merged commit e681040 into master Apr 29, 2016
@arlimus arlimus deleted the ap/file-basename branch April 29, 2016 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexpop @arlimus @chef-supermarket