Provide service params

[alexpop]

Replacing the current method of accessing these params:

describe service('avahi-daemon').info[:properties]['UnitFileState'] do
  it { should be 'enabled' }
end

with this:

  # This test will succeed if the service is not enabled
  describe service('avahi-daemon').params do
    its('UnitFileState') { should_not eq 'enabled' }
  end

  # This test will fail with expected: "enabled", got nil
  describe service('MissingInActionService').params do
    its('MissingInActionParam') { should eq 'enabled' }
  end

1. Not happy with the hashie dependency, but wanted to share the vision and start the discussion.
2. Should we make the info method private now?
3. params looks to be an internal inspec way of handing attributes. Is properties a better name for this method? For example:

  describe service('avahi-daemon').properties do
    its('UnitFileState') { should_not eq 'enabled' }
  end

[arlimus]

+1 in making info private; is there anything in info, that is not exposed via accessors? anything that shouldn't be exposed via accessors but only via info?

[alexpop]

inspec> s.info
=> {:name=>"sshd.service",
 :description=>"OpenSSH server daemon",
 :installed=>true,
 :running=>true,
 :enabled=>true,
 :type=>"systemd",
 :params=>
  {"Type"=>"simple",
   "Restart"=>"on-failure",

Right now, out of this bunch, only installed, running and enabled are available directly. Missing name, description and type

[chris-rock]

I like the service('avahi-daemon').params approach because it works in harmony with other resources we have. We could easily have:

 describe service('sshd')do
    its('name') { should eq 'sshd.service' }
   its('description') { should eq 'OpenSSH server daemon' }
   its('type') { should eq 'systemd' }
 end

[alexpop]

Ok, with the latest code, this is working now:

  describe service('avahi-daemon').params do
    its('UnitFileState') { should_not eq 'enabled' }
  end

  describe service('sshd') do
    its('type') { should eq 'systemd' }
    its('name') { should eq 'sshd.service' }
    its('description') { should eq 'OpenSSH server daemon' }
    its('params.UnitFileState') { should eq 'enabled' }
  end

[chris-rock]

can we remove the srv?

[chris-rock]

@alexpop Implementation is very good. I would like to remove all srv code, where we replaced it with specific test. Also I would add the .params tests for all systemd tests (those have been covered by the info object before):

 describe service('avahi-daemon').params do
    its('UnitFileState') { should_not eq 'enabled' }
  end

[chris-rock]

Hi Alex, would it make sense to re-add the systemd tests:

_(resource.params).must_equal {object}'

[chris-rock]

Awesome addition @alexpop