Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contain_match, add none_match #736

Merged
merged 1 commit into from
May 11, 2016
Merged

Fix contain_match, add none_match #736

merged 1 commit into from
May 11, 2016

Conversation

alexpop
Copy link
Contributor

@alexpop alexpop commented May 11, 2016

Other changes:

  • update matchers doc and add more integration tests
  • allow non-string data types and non-arrays

contain_match was incorrectly reporting success for a test like this:

describe ['lemon', 'ginger', 'grapes'] do
  it { should contain_match /^ginnnnnnnnnnnn/}
end

update matchers doc and add more integration tests
allow non-string data types and non-arrays
@alexpop alexpop added Type: Bug Feature not working as expected Type: Enhancement Improves an existing feature labels May 11, 2016
@chris-rock
Copy link
Contributor

I like the addition of the none_matcher

@chris-rock chris-rock merged commit 79e291c into master May 11, 2016
@chris-rock chris-rock deleted the ap/matchers4me branch May 11, 2016 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Feature not working as expected Type: Enhancement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants