Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support intra-libraries file referencing + loading #780

Merged
merged 1 commit into from
Jun 3, 2016
Merged

support intra-libraries file referencing + loading #780

merged 1 commit into from
Jun 3, 2016

Conversation

arlimus
Copy link
Contributor

@arlimus arlimus commented Jun 3, 2016

solves #779

@arlimus arlimus added the Type: Enhancement Improves an existing feature label Jun 3, 2016
@chris-rock
Copy link
Contributor

This looks really cool and allows us to load files from an archive. I like that.

@arlimus
Copy link
Contributor Author

arlimus commented Jun 3, 2016

The nasty part is the required evil eval in there. Ruby's require relies on files on the system, so we have to emulate around that fact to make sure it eats our input streams (as you can run inspec from http/tgz/...). May be a necessary evil for now...

@arlimus arlimus merged commit e4e2905 into master Jun 3, 2016
@arlimus arlimus deleted the dr/lib-loading branch June 3, 2016 21:03
@chris-rock chris-rock mentioned this pull request Jul 7, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arlimus @chris-rock