improve wmi resource

[chris-rock]

This improves the wmi resource:

# new syntax
describe wmi({
  class: 'RSOP_SecuritySettingNumeric',
  namespace: 'root\\rsop\\computer',
  filter: 'KeyName = \'MinimumPasswordAge\' And precedence=1'
}) do
   its('Setting') { should eq 1 }
end

# deprecated syntax
describe wmi('RSOP_SecuritySettingNumeric', {
  namespace: 'root\\rsop\\computer',
  filter: 'KeyName = \'MinimumPasswordAge\' And precedence=1'
}) do
   its('Setting') { should eq 1 }
   its('setting') { should eq 1 }
end

In addition this resource supports query now:

describe wmi({
  namespace: 'root\rsop\computer',
  query: "SELECT Setting FROM RSOP_SecuritySettingBoolean WHERE KeyName='LSAAnonymousNameLookup' AND Precedence=1"
}) do
  its('Setting') { should eq false }
end

[arlimus]

Could this be shortened?
Maybe

@options = opts || {}
if wmiclass.is_a?(Hash)
  @options.merge!(wmiclass)
else
  @options[:class] = wmiclass
end

Should we add a deprecation warning for the old wmiclass mode?

[chris-rock]

I like the shortened version

[arlimus]

Awesome, kudos @chris-rock 👍