Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add boolean support for cmp matcher #801

Merged
merged 1 commit into from
Jun 19, 2016
Merged

Conversation

chris-rock
Copy link
Contributor

cmp matcher learns the comparison of string values with boolean values:

describe true do
    it { should cmp 'true' }
    it { should cmp 'True' }
    it { should cmp true }
  end

  describe false do
    it { should cmp 'false' }
    it { should cmp 'False' }
    it { should cmp false }
  end

@chris-rock chris-rock added the Type: Enhancement Improves an existing feature label Jun 18, 2016
@arlimus
Copy link
Contributor

arlimus commented Jun 19, 2016

This should get us to feature-completion on cmp, awesome addition @chris-rock 👍
kudos !!

@arlimus arlimus merged commit 40886de into master Jun 19, 2016
@arlimus arlimus deleted the chris-rock/cmp-boolean branch June 19, 2016 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants