Handle xinetd config with only one entry

[chris-rock]

This PR handles a bug reported by @kdshah1 via gitter:

is this the correct way to check xinetd services are disabled?

        describe xinetd_conf.services('telnet') do
         it{ should be_disabled }
       end

It fails with following message:

 ✖  services-04: System Must Disable telnet Service. (1 failed)
     expected `Xinetd config /etc/xinetd.conf with service == "telnet".disabled?` to return true, got false

whereas my telnet file under /etc/xinet.d reads this:

 # default: on
# description: The telnet server serves telnet sessions; it uses \
#       unencrypted username/password pairs for authentication.
service telnet
{
        disable = yes
        flags           = REUSE
        socket_type     = stream
        wait            = no
        user            = root
        server          = /usr/sbin/in.telnetd
        log_on_failure  += USERID
}

The problem was, that the xinetd resource was expecting multiple entries via includedir /etc/xinetd.d. This PR also adds another test to catch that case.

[chris-rock]

should fix #845

[stevendanna]

Minro style point. You might consider avoidng the type check and doing:

Array(v).each { |service| service.params['service'] = name }

Array(v) will coerce a scalar into an array but won't touch the arg if it is already an array:

Airb(main):001:0> Array(4)
=> [4]
irb(main):002:0> Array([4])
=> [4]

[chris-rock]

Yes, that makes it more save.

[stevendanna]

Overall this looks good to me. I'm wondering if in the future the thing we actually want to store is a merged view of the config for a given service.

[chris-rock]

Lets double-check if we should move this logic to the parser

[arlimus]

I like the current version and the functionality in here 👍
Imho the discussion of splitting it up is a second iteration. Also is there a benefit of moving it to the parser? @stevendanna sounds like a great idea, let's track it as a separate idea