Support either /dev/kcore or /dev/core in the tests #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hrm. This seems to be behaving differently for me locally vs in travis. I'll sort it out locally so it behaves the same way it does in travis. |
stevendanna
force-pushed
the
ssd/core-not-kcore
branch
from
015af62
to
a9c9857
Compare
stevendanna
changed the title
|
@stevendanna that looks great. One question: Is Update: travis is not linking |
chris-rock
changed the title
|
@chris-rock Unfortunately that is one of the first things I tried. It doesn't seem like Travis links /dev/core. |
In many linux distributions a link to /proc/kcore is placed at `/dev/core`. In TravisCI we see it at `/dev/kcore`. To avoid tests failing for some developers locally, we support either location.
chris-rock
force-pushed
the
ssd/core-not-kcore
branch
from
6be03a9
to
f309022
Compare
chris-rock
changed the title
|
Great work @stevendanna |
chris-rock
added
Type: Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think
/dev/coreis the more usual location but/dev/kcoreis what appears on Travis. This allows the tests to run for me locally usingDocker for Mac