Improve windows support of omnibus installer #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stevendanna @chris-rock @arlimus @alexpop I still need to fix the icons but the rest of it should be ready to look at. |
|
|
||
| suites: | ||
| - name: default | ||
| - name: inspec |
There was a problem hiding this comment.
any reason why we renamed that?
There was a problem hiding this comment.
None in particular - just cosmetic. If I've a bunch of VMs running, setting the suite name correctly helps identify the VM inside virtual box. Otherwise everything looks like "kitchen-omnibus-default-windows-2012r2-standard..."
|
Nice work! |
ksubrama
changed the title
chris-rock
force-pushed
the
ksubrama/win_omnibus
branch
from
cb585d6
to
895c587
Compare
chris-rock
force-pushed
the
ksubrama/win_omnibus
branch
from
895c587
to
016e970
Compare
chris-rock
changed the title
|
fixes #889 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.