Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce dependency resolution (experimental) #891

Merged
merged 5 commits into from
Aug 11, 2016
Merged

Conversation

arlimus
Copy link
Contributor

@arlimus arlimus commented Aug 8, 2016

This commit is the foundation of the dependency resolution as described in #888 .

It currently only works with local dependencies, as seen in the example inheritance profile.

Tests and full resolution are coming next on the path to an MVP implementation.

@arlimus arlimus added the Type: Enhancement Improves an existing feature label Aug 8, 2016
@arlimus arlimus changed the title introduce dependency resolution WIP: introduce dependency resolution Aug 8, 2016
@arlimus arlimus force-pushed the dr/depends branch 3 times, most recently from 4cefc85 to 68f52e4 Compare August 9, 2016 09:10
@arlimus arlimus mentioned this pull request Aug 9, 2016
8 tasks
@arlimus arlimus changed the title WIP: introduce dependency resolution WIP: introduce dependency resolution (MVP) Aug 9, 2016
@arlimus arlimus added this to the 0.30.0 milestone Aug 9, 2016
@alexpop
Copy link
Contributor

alexpop commented Aug 10, 2016

Dom, are resources from dependent profiles not working for now in parent profile?

I tried adding:

describe gordon_config do
  it { should exist }
end

to inheritance/controls/example.rb but it's failing.

This commit is the foundation of the dependency resolution as described in #888 .

It currently only works with local dependencies, as seen in the example inheritance profile.

Tests and full resolution are coming next on the path to an MVP implementation.
@chris-rock
Copy link
Contributor

fixes #533

Signed-off-by: Steven Danna <steve@chef.io>
Signed-off-by: Steven Danna <steve@chef.io>
Signed-off-by: Steven Danna <steve@chef.io>
@arlimus arlimus changed the title WIP: introduce dependency resolution (MVP) introduce dependency resolution (MVP) Aug 11, 2016
@chris-rock chris-rock changed the title introduce dependency resolution (MVP) introduce dependency resolution (experimental) Aug 11, 2016
@chris-rock
Copy link
Contributor

@alexpop we will address that in further PRs. Great work @arlimus and @stevendanna

@chris-rock chris-rock merged commit 81563b8 into master Aug 11, 2016
@chris-rock chris-rock deleted the dr/depends branch August 11, 2016 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants