Add readline ignore markers to color escape codes in the shell #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice addition @stevendanna +1 |
Previously, if you typed more than 20 characters at the prompt and attempted pressed Ctrl+a (readline's "Move to start of line" command), your prompt would appear at the ~11th character from the start of the line, unable to go further back. This was a result readline counting the terminal escape sequences we use for color output as part of the line. Wrapping these sequences in \001 and \002 instructs readline to ignore them when doing calculations regarding line-length, resolving the problem.
chris-rock
force-pushed
the
ssd/shell-readline
branch
from
dc95d7d
to
b4b6792
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if you typed more than 20 characters at the prompt and
attempted to press Ctrl+a (readline's "Move to start of line" command),
your prompt would appear at the ~11th character from the start of the
line, unable to go further back.
This was a result readline counting the terminal escape sequences we use
for color output as part of the line.
Wrapping these sequences in \001 and \002 instructs readline to ignore
them when doing calculations regarding line-length, resolving the
problem.