Improve detection of postgresql conf dir and data dir #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,6 +3,7 @@ | |||
| # author: Dominik Richter | |||
| # author: Christoph Hartmann | |||
| # license: All rights reserved | |||
| require 'resources/directory' | |||
There was a problem hiding this comment.
we do not need a require here, since its available by default via inspec.directory
|
This is a great addition @stevendanna |
stevendanna
force-pushed
the
ssd/pgconf-location
branch
from
18b7cb2
to
739a2d9
Compare
Redhat conf_dir detection was regressed in 57d7275 which inadvertently removed the setting of @conf_dir. Any attempt to use the postgres resource on RHEL would rain an exception: inspec> postgres.data_dir TypeError: no implicit conversion of nil into String Further, the redhat detection code appears to assume that RHEL always uses versioned data directories. This however, does not appear to be the case: $ cat /etc/redhat-release CentOS release 6.7 (Final) $ sudo ls /var/lib/pgsql/ backups data pgstartup.log The code now can handle both versioned and un-versioned directory formats on RHEL. Further, it provides diagnostic warnings about uncertainty in the discovered data directories and configuration directories. Signed-off-by: Steven Danna <steve@chef.io>
chris-rock
force-pushed
the
ssd/pgconf-location
branch
from
739a2d9
to
c71f5cd
Compare
chris-rock
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redhat conf_dir detection was regressed in 57d7275 which inadvertently
removed the setting of @conf_dir. Any attempt to use the postgres
resource on RHEL would rain an exception:
Further, the redhat detection code appears to assume that RHEL always
uses versioned data directories. This however, does not appear to be the
case:
The code now can handle both versioned and un-versioned directory
formats on RHEL. Further, it provides diagnostic warnings about
uncertainty in the discovered data directories and configuration
directories.
Fixes #494
Signed-off-by: Steven Danna steve@chef.io