Add iis_site resource #907
Conversation
| # <protocol> <bindingInformation> {if https "sslFlags=<sslFlags>"} | ||
| # the binding is a collection and there will always be at least one entry per site | ||
| if site['bindings']['Collection'] | ||
| site['bindings']['Collection'].each do |binding| |
There was a problem hiding this comment.
It may be better to use http://ruby-doc.org/core-2.2.0/Array.html#method-i-map for that use case
There was a problem hiding this comment.
Good suggestion. Thanks.
There was a problem hiding this comment.
@chris-rock was something like this what you meant?
site['bindings']['Collection'].map { |k, str|
k['protocol'] <<
" " <<
k['bindingInformation'] <<
(k['protocol'] == 'https' ? ' sslFlags=' << flags : '')
}
There was a problem hiding this comment.
The idea was to remove the bindings_array = [] object
|
@chrisevett Great effort, this is a great resource. Let just make some improvements. Compared to the original http://serverspec.org/resource_types.html#iis_website it is easier to read!
Let me know if something is unclear. |
|
@chris-rock I'll make the updates you suggested. Thanks for the feedback. |
|
Hey @chrisevett Please let me know when you think its ready, I am going to review it then again |
| @@ -5,7 +5,7 @@ | |||
| description 'This cookbook prepares the test operating systems' | |||
| version '1.0.0' | |||
|
|
|||
| depends 'apt' | |||
| depends 'iis' | |||
There was a problem hiding this comment.
is there any reason you removed the apt cookbook?
There was a problem hiding this comment.
I undid this change.
|
@chris-rock Thanks for being patient with my poor ruby skills. |
|
@chrisevett it would be great if you could squash that to no more that 5 commits. |
|
|
||
| return unless node['platform_family'] == 'windows' | ||
|
|
||
| # make sure the iis windows feature is installed |
There was a problem hiding this comment.
I think we do not need the indent here.
There was a problem hiding this comment.
I removed the indent.
|
@chris-rock this is ready for review once more. Thanks! |
|
|
||
| * ``iis_site()`` must specify a web site name | ||
| * ``'website'`` is the web site name | ||
| * ``'service_name'`` is a service listed in the ``inetd.conf`` file |
There was a problem hiding this comment.
I think we do not need the service_name here
|
Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog. Non-GitHub Verified CommittersThere are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute. |
|
Awesome work @chrisevett The resource works great 👍 I'll added some super minor improvements. Then lets just rebase this PR to latest master via |
|
I'll merge this PR as soon as you're done |
|
Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future. |
|
Rebase and edits are complete. Thanks. |
|
Thanks again for hard work @chrisevett 💯 |
I modeled this after serverspec and then added a check for bindings. The janky format we check for (you'll notice some string mangling) matches the output that gets generated by the get-website cmdlet in powershell. I thought that would be the easiest way to write tests.