Improve inspec shell by having it evaluate describe/control blocks. #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note - the "-c" arm of the shell already works (I have tested it locally). I'm trying to figure out how to make the shell work. |
ksubrama
force-pushed
the
ksubrama/shell
branch
from
056143f
to
30e1521
Compare
| @@ -13,11 +13,11 @@ class Fetcher < Fetchers::Url | |||
| priority 500 | |||
|
|
|||
| def self.resolve(target, opts = {}) | |||
| return nil unless URI(target).scheme == 'supermarket' | |||
| return nil unless target.is_a?(String) | |||
There was a problem hiding this comment.
we still need to ensure that the scheme is supermarket
chris-rock
force-pushed
the
ksubrama/shell
branch
from
30e1521
to
d7e667d
Compare
ksubrama
force-pushed
the
ksubrama/shell
branch
from
d7e667d
to
3b02087
Compare
ksubrama
force-pushed
the
ksubrama/shell
branch
from
aa9f12f
to
e43cdf2
Compare
ksubrama
force-pushed
the
ksubrama/shell
branch
from
e43cdf2
to
0cc8fc5
Compare
|
Fix #240 |
ksubrama
changed the title
ksubrama
force-pushed
the
ksubrama/shell
branch
from
bf7419f
to
82c3dda
Compare
chris-rock
changed the title
chris-rock
changed the title
| else | ||
| res = run_command(o) |
There was a problem hiding this comment.
we should reflect the --format option here and do the json dump if activated
There was a problem hiding this comment.
run_command should already print the json output. It's no longer using a mock runner - it's doing the real rspec thing which handles --format on its own.
chris-rock
force-pushed
the
ksubrama/shell
branch
from
444322c
to
2e09090
Compare
|
This fixes #240 |
chris-rock
force-pushed
the
ksubrama/shell
branch
from
2e09090
to
45dd726
Compare
chris-rock
force-pushed
the
ksubrama/shell
branch
from
45dd726
to
7843852
Compare
chris-rock
force-pushed
the
ksubrama/shell
branch
from
7843852
to
2d4c3e3
Compare
chris-rock
force-pushed
the
ksubrama/shell
branch
from
2d4c3e3
to
04c9b34
Compare
chris-rock
force-pushed
the
ksubrama/shell
branch
from
30ab290
to
b9a8e95
Compare
chris-rock
force-pushed
the
ksubrama/shell
branch
from
b9a8e95
to
fc66591
Compare
chris-rock
force-pushed
the
ksubrama/shell
branch
from
fc66591
to
33ae22d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@arlimus @chris-rock @jbussdieker @alexpop
This definitely has bugs in it but the is the general strategy I came up with last night after diving head-first into inspec and pry.