Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows ports with pid and process name #912

Merged
merged 1 commit into from
Aug 12, 2016
Merged

Conversation

alexpop
Copy link
Contributor

@alexpop alexpop commented Aug 12, 2016

This PR improves the port resource for Windows. Two main changes went in:

  1. Only LISTENING ports are retrieved same as with linux
  2. netstat is used in favor of Get-NetTCPConnection because it gives us the valuable PID and process name behind the listening port.

@alexpop alexpop added the Type: Enhancement Improves an existing feature label Aug 12, 2016
@alexpop
Copy link
Contributor Author

alexpop commented Aug 12, 2016

 #<struct  port=49156, address="::", protocol="tcp", process="lsass.exe", pid=484, listening?=nil>,
 #<struct  port=5355, address="0.0.0.0", protocol="udp", process="Dnscache", pid=992, listening?=nil>,
 #<struct  port=137, address="10.0.2.15", protocol="udp", process="System", pid=4, listening?=nil>,

@arlimus
Copy link
Contributor

arlimus commented Aug 12, 2016

This is a great improvement, thank you @alexpop !! 👍

@arlimus arlimus merged commit 5f1d83f into master Aug 12, 2016
@arlimus arlimus deleted the ap/port-win-process branch August 12, 2016 18:59
@chris-rock chris-rock modified the milestone: 0.31.0 Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants