ssh_config parse should be case insensitive #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| it 'is case insensitive' do | ||
| resource = load_resource('ssh_config') | ||
| _(resource.gssapiauthentication).must_equal 'no' |
There was a problem hiding this comment.
You might consider adding an assertion here testing other capitalizations. This test would fail to catch a regression where we only accepted lowercase specifications.
|
Overall this looks good to me. I think this is a good solution for now. If we wanted to get fancier, rather than storing the configuration in a plain ruby hash, we could create a wrapper data type that intermediated access to the underlying data. However, until we have another use case for that, I think the one-time transformation is relatively clean. |
|
thanks!! just pushed up a commit to test with resource.GSSAPIAuthentication and removed that debugging cruft |
vjeffrey
force-pushed
the
vj/case-insens-ssh-conf
branch
from
d9ebda3
to
c7e055d
Compare
chris-rock
force-pushed
the
vj/case-insens-ssh-conf
branch
from
c7e055d
to
6f198f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#759
Please let me know if there's a cleaner way to do this. I looked around and tried to find a different way (one that doesn't involve me messing with the hash), but this was the only solution I could find. Happy to change it up if there's something better out there :)