remove tests and dev dependencies from released gem #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,6 +18,7 @@ group :test do | |||
| gem 'rubocop', '~> 0.36.0' | |||
| gem 'simplecov', '~> 0.10' | |||
| gem 'concurrent-ruby', '~> 0.9' | |||
| gem 'mocha', '~> 1.1' | |||
There was a problem hiding this comment.
its good to move it to the gemfile 👍
Developers use the github repo to get full access to the development of this gem. The fixed (non git-ls-files) approach to packaging files has led to a 30mb gem recently, this will prevent that from happening again.
group test gems together.
arlimus
force-pushed
the
dr/remove-tests
branch
from
82b6ad6
to
161bd63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focus on the git repo for development, i.e. group all development/test dependencies in
Gemfileand remove thetestfolder from the released gem.This together with the fact that we are not using git-ls-files has led to a 30mb gem recently!