inspec compliance version fails gracefully when no server config #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
force-pushed
the
vj/no-token-version-error-msg
branch
from
c3f3969
to
459c5c3
Compare
|
This needs to be rebased once #928 is merged |
|
Great work @vjeffrey I added some minor improvements:
|
chris-rock
force-pushed
the
vj/no-token-version-error-msg
branch
from
d0dca3e
to
b75b8ab
Compare
| describe command("#{inspec_bin} compliance version") do | ||
| its('stdout') { should include 'Server configuration information is missing' } | ||
| its('stderr') { should eq '' } | ||
| its('exit_status') { should eq 0 } |
There was a problem hiding this comment.
Might we want to exit 1 in this case?
There was a problem hiding this comment.
good idea @stevendanna, @vjeffrey could you add a PR to cover that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
having trouble running the tests for this at the moment, so i'm putting this up while I work on getting those done.
fixes #894