Fix recursive deps for path-based deps #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| def initialize(vendor_index, opts = {}) | ||
| @logger = opts[:logger] || Logger.new(nil) | ||
| @debug_mode = false # TODO: hardcoded for now, grab from options | ||
|
|
||
| @vendor_index = vendor_index | ||
| @cwd = opts[:cwd] || './' |
There was a problem hiding this comment.
I would move that to the cli and set the default there, not as part of the code.
There was a problem hiding this comment.
Maybe we can reuse the profile path here to avoid adding a new option? Overall I think we'll need to refactor a lot of this current working directory as it is currently very confusing. Once we have the fetchers/vendoring more flushed out, I think this level of the code won't need to worry about this.
Signed-off-by: Steven Danna <steve@chef.io>
chris-rock
force-pushed
the
ssd/dep-recurse-1
branch
from
2ace8fb
to
34ae312
Compare
|
related to #888 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that we always instantiate an Inspec::Requirement and thread through the current working directory of the inspec.yml.
Signed-off-by: Steven Danna steve@chef.io