fail gracefully on inspec compliance profiles when bad token is provided

[vjeffrey]

just a quick fix to handle inspec compliance profiles when an incorrect token has been previously provided.

@chris-rock

[stevendanna]

Are we sure the only case where data == '' is a 401? My first impression when reading this code is that I'm a bit surprised that this isn't a case statement on the http response code. Also, if possible it feels like this is a case where we would want to exit with a non-zero exit status.

[vjeffrey]

good point, thanks!! ya, i'll rework this a bit later -- a case statement on the http response code sounds like the right thing to do there

[chris-rock]

agree with @stevendanna we should check the http code

[chris-rock]

We should add a message that indicates an error. I assume most users do not know http codes by heart ;-)

[vjeffrey]

oops, ya! i'll add it :)

[vjeffrey]

i'm getting some odd travis failures on ubuntu.... :(

[vjeffrey]

is this ok? @chris-rock or were you thinking something else/more specific?

[stevendanna]

I'm not familiar with the compliance API, but response.message will typically be filled with the error message that the server sent back, so you might try something like:

puts "An unexpected error occurred (HTTP #{response_code}): #{response.message}"

[chris-rock]

Cool idea @stevendanna

[chris-rock]

In addition to that the API class should not do any output. Only the cli class should do that. therefore we need to return the message as the other methods do it.

[stevendanna]

Only the cli class should do that. therefore we need to return the message as the other methods do it.

👍 On this. I was going to potentially recommending creating a custom exception that you could raise in the case of an HTTP error. The exception can contain the message the cli class should print on rescue. However, I noticed that this code base stays away from exceptions for the most part.

[vjeffrey]

oooh nice! thanks! i'll add the message stuff and have the api class the return the message so the cli class can take care of the output :)

[chris-rock]

@stevendanna the whole API implementation needs a refactor, because I want to merge it with the content in our audit cookbook. But lets not address this in that iteration