return token stored message on login #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjeffrey
force-pushed
the
vj/update-token-msg
branch
from
fa7cfe5
to
d893d3b
Compare
| elsif !options['user'].nil? && !options['token'].nil? | ||
| # access token | ||
| success, msg = store_access_token(url, options['user'], options['token'], options['insecure']) | ||
| msg = store_access_token(url, options['user'], options['token'], options['insecure']) |
There was a problem hiding this comment.
store_access_token returns an array, so now msg will be an array (https://github.com/chef/inspec/pull/932/files#diff-e2fd7d8d44ceb659a9c3a3a7984c53a4R237), which will cause the print statement below to print both items:
There was a problem hiding this comment.
oh, oops, sorry. i took that out cause of a lint complaint, I should have just left it in with a leading underscore....late night changes :) I'll switch it up
vjeffrey
force-pushed
the
vj/update-token-msg
branch
from
d893d3b
to
a9e83d3
Compare
chris-rock
force-pushed
the
vj/update-token-msg
branch
from
a9e83d3
to
24a2c5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
at the moment, on master, we respond with 'successfully authenticated' even when there's an obviously wrong token, so this is just a small change to send back the actual message instead:
