Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix command evaluation for inspec shell -c #943

Merged
merged 2 commits into from
Aug 23, 2016
Merged

Fix command evaluation for inspec shell -c #943

merged 2 commits into from
Aug 23, 2016

Conversation

ksubrama
Copy link

No description provided.

@chris-rock chris-rock added this to the 0.32.0 milestone Aug 19, 2016
@ksubrama
Copy link
Author

Fixed #942

@ksubrama
Copy link
Author

@stevendanna @chris-rock @arlimus @vjeffrey Yay tests pass. I think we have a good set of functional tests. Clearly there can be more. I kinda want to get these in before I spend more time over testing this.

@ksubrama ksubrama self-assigned this Aug 22, 2016
@ksubrama ksubrama added Type: Bug Feature not working as expected feature request labels Aug 22, 2016
arlimus
arlimus reviewed Aug 23, 2016
View reviewed changes
lib/inspec/cli.rb
@@ -162,22 +162,23 @@ def shell_func
diagnose
o = opts.dup

log_device = opts['format'] == 'json' ? nil : STDOUT
json_output = ['json', 'json-min'].include?(opts['format'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!!

@arlimus
Copy link
Contributor

arlimus commented Aug 23, 2016

These look great, especially the large selection of additional tests. There can always be more, but the tricky part is to select the right amount of tests and I like the selection you've made.

The only slight thing we should keep in mind is this:
https://github.com/chef/inspec/pull/943/files#diff-ca3dd31f0db2b13fca008d2b3a0000b8L138
Since this is a publicly available function that we are removing, it may cause issues in other projects. I do however like that it is being removed, i.e.:

👍

Thank you Kartik, this is a great improvement 😄

@arlimus arlimus merged commit 3222670 into master Aug 23, 2016
@arlimus arlimus deleted the ksubrama/shell2 branch August 23, 2016 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ksubrama ksubrama

Labels
Type: Bug Feature not working as expected
Projects
None yet
Milestone
0.32.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ksubrama @arlimus @chris-rock @chef-supermarket