print controls, then tests; print header of describe, then individual test results

[vjeffrey]

@arlimus @chris-rock does this look right??

fixes #918

just pushed a commit to attempt to fix part of #899

i marked this as a wip just because i want to make sure that i have the right idea of what this should look like :) please let me know!! (also, I don't have any tests on them yet)

[vjeffrey]

hmmm. wondering if the describe block should have the same kind of summary line as in the control. so it would say Users vjeffrey (1 failed) and then have the test cases below and tabbed in just as it is now. it would make it more clear.....and it would fit with what we do for controls. i might try to throw up another commit to see what that looks like

[arlimus]

Desired output:

RSpec'y reporting

describe something do
   it { should do_sth }
   it { should be_sth }
end

We want what users already know from RSpec in the output:

Something
    it should do_sth
    it should be_sth

Mixing Controls and describe's

Given a file with:

control 1 ...
describe sth ...
control 2 ...
describe sth_else ...
...

we want the default output to be:

Profile: ...
Version: ...

v control-1: This is something in a control that passed ...
x control-2: This is something in the control that failed ...
...

sth
   should look_like this
   and also this
sth_else
   should be indented like RSpec 
....

• Group controls and group describe contents in the output
• 1-2 lines of whitespace between both groups

[vjeffrey]

[vjeffrey]

no reason to take in color anymore, i'm not using it, i should remove it. also, the name of this should change, since we're printing fails skips and passes

[arlimus]

@vjeffrey This looks great!! Could you add integration tests?

afaics: describe-only, controls should be covered, and the mixed output. See test/functional/inspec_exec_test.rb

[vjeffrey]

my tests are being annoying. i'll fix them in a bit

[vjeffrey]

oh shoot there's a couple tests that seem to be failing due to my change. not sure why though....i'll look.

so the tests that are failing here for me are failing for me on master too. hmmmm

[vjeffrey]

i decided to push an extra commit up real quick to fix up the spacing and stuff like you mentioned @chris-rock

[chris-rock]

Thanks @vjeffrey for this great improvement. I would some edge cases and will track those in a followup ticket #984