Speed up windows package lookup #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is supposed to fix #86 but I can't figure out what the unit tests are doing and what and _() function is.... I'll look into this tomorrow. |
| @@ -53,8 +53,11 @@ | |||
|
|
|||
| # windows | |||
| it 'verify windows package parsing' do | |||
| STDERR.puts "FUCK EVERYTHING!" | |||
There was a problem hiding this comment.
We probably don't want to commit this :D
There was a problem hiding this comment.
@ksubrama Its not acceptable to place offensive language in a PR.
chris-rock
force-pushed
the
ksubrama/package
branch
from
1d56a67
to
d8101de
Compare
chris-rock
changed the title
|
@ksubrama thanks for the new implementation. I added unit and integration tests for that implementation |
chris-rock
force-pushed
the
ksubrama/package
branch
from
d8101de
to
1989c25
Compare
| packages.each { |pkg| | ||
| package_name = pkg.strip | ||
| # get wmi package information | ||
| cmd = powershell("Get-WmiObject -Class Win32_Product | Where-Object {$_.Name -eq '#{package_name}'} | Select-Object -Property Name,Version,Vendor,PackageCode,Caption,Description | ConvertTo-Json") |
There was a problem hiding this comment.
👍 I like that we are using the old command here to ensure we match the same output we would have gotten with the old code.
|
👍 This looks reasonable to me. |
|
fixes #86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.