Add Ruby 2.3 to the test matrix, make it the primary test for most suites #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@chris-rock it looks to be failing on windows ruby 2.3: https://ci.appveyor.com/project/chef/inspec/build/1.0.1258/job/8iwny2t86wi4p7e4 |
|
I can reproduce that behavior on my local Windows instance. The problem seems to be located here: https://github.com/chef/train/blob/master/lib/train.rb#L37-L47 @ksubrama any ideas? |
|
Thanks @jkeiser Lets find out, why this is failing on Windows with ruby 2.3.1 |
|
Fixed with #980 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chef and ChefDK will soon ship with Ruby 2.3, so we should make sure the inspec suite works on it.