Fix bundle install on Ruby 2.1.9
#975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,8 +8,9 @@ if Gem::Version.new(RUBY_VERSION) <= Gem::Version.new('1.9.3') | |||
| gem 'net-ssh', '~> 2.9' | |||
| end | |||
|
|
|||
| if Gem::Version.new(RUBY_VERSION) <= Gem::Version.new('2.1.0') | |||
| if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.2.0') | |||
|
@jkeiser awesome fix 💯 |
|
I am going to merge it although not all kitchen test pass. This is a know issue in https://github.com/chef-cookbooks/compat_resource cookbook. |
jerryaldrichiii
added a commit
that referenced
this pull request
Dec 1, 2018
After digging I see that PR #975 fixed `bundle install` on 2.1.9 about two years ago. The minimum required version of Ruby for InSpec is 2.2. This updates our Gemfile to remove any logic for Ruby `< 2.2.2`. The Gemfile should only be used for development...but I could be wrong here. Let me know if you think there will be any issues. Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
jquick
pushed a commit
that referenced
this pull request
Dec 6, 2018
After digging I see that PR #975 fixed `bundle install` on 2.1.9 about two years ago. The minimum required version of Ruby for InSpec is 2.2. This updates our Gemfile to remove any logic for Ruby `< 2.2.2`. The Gemfile should only be used for development...but I could be wrong here. Let me know if you think there will be any issues. Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
wiebe
pushed a commit
to wiebe/inspec
that referenced
this pull request
Dec 10, 2018
After digging I see that PR inspec#975 fixed `bundle install` on 2.1.9 about two years ago. The minimum required version of Ruby for InSpec is 2.2. This updates our Gemfile to remove any logic for Ruby `< 2.2.2`. The Gemfile should only be used for development...but I could be wrong here. Let me know if you think there will be any issues. Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rackis another gem whose latest version does not work on Ruby 2.1.9.I also fixed it so
<= 2.1.0became< 2.2, since2.1.9was not being covered.Finally, I added 2.1.9 to the Travis matrix the current
chefandchef-dkstable releases still run 2.1.9, and gave specific versions to all the Rubies we run, since on Travis 2.1 means 2.1.0, which has known bugs and which no one runs.