Minor refactor and explanatory comments #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevendanna
force-pushed
the
ssd/comments
branch
from
b443b9e
to
6029747
Compare
chris-rock
force-pushed
the
ssd/comments
branch
from
6029747
to
003c841
Compare
This is a minor refactor that I did while studying our loading code in preparation for some deeper changes to how content loading works. The overall goal of the refactor is to remove a few places where we were passing a generic options hash and then only accessing a single item. The comment hopefully clarifies to new developers in the code base how content loading works at a high level. Signed-off-by: Steven Danna <steve@chef.io>
stevendanna
force-pushed
the
ssd/comments
branch
from
003c841
to
4941ec6
Compare
| @@ -15,9 +15,8 @@ module Inspec | |||
| class Profile # rubocop:disable Metrics/ClassLength | |||
| extend Forwardable | |||
|
|
|||
| def self.resolve_target(target, opts) | |||
| def self.resolve_target(target) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor refactor that I did while studying our loading code in
preparation for some deeper changes to how content loading works. The
overall goal of the refactor is to remove a few places where we were
passing a generic options hash and then only accessing a single item.
The comment hopefully clarifies to new developers in the code base how
content loading works at a high level.
Signed-off-by: Steven Danna steve@chef.io