inspec demo #989

vjeffrey · 2016-08-26T16:15:35Z

ok, so obviously this is not ready ready, but it's a start, so i'm putting up a PR for it...i think this works for the whole "viability gate" thing. There is much more to do, but i think this is a good spot to commit something. Please list out ANYTHING you can think of that you see needing improvement/want implemented, so i can keep a list as I truck along.
fixes most of #956

stevendanna · 2016-08-26T16:27:30Z

www/app/app.component.ts

+
+  evalInput(value) {
+    if (value.match(/^inspec exec\s*examples\/profile\/controls\/example.rb\s*/)) {
+      this.getResponse(value, "inspec_exec");


This makes sense for the viability demo, but I think we might want to bundle the response data (or a segment of it) in a single blob that we send to the client to avoid a lot of round tripping.

stevendanna · 2016-08-26T16:29:46Z

We probably want to either strip the color control characters from our recording or figure out how to translate those into the right colors in the browser:

stevendanna · 2016-08-26T16:31:55Z

It is hard to get a screenshot of, but the cursor appears on the line below the $ rather than on the same line like it would in a terminal. Also, when you hit enter on your command, the command you entered moves down a line while the behavior in the terminal would be for the output to appear and then a new prompt to appear with your cursor on it.

stevendanna · 2016-08-26T16:33:24Z

Like the pattern matching on the errors, very cool, but it seems to have gone wrong a little bit:

inspec exec /does/not/exist

 Could not fetch inspec profile in "examples/profile/example.rb".

stevendanna · 2016-08-26T16:34:46Z

The instructions don't seem to reposition if I make my browser window smaller.

stevendanna · 2016-08-26T16:35:44Z

@vjeffrey Listed some issues I found, but overall this was very easy to get running and worked immediately, very cool start.

stevendanna · 2016-08-26T16:41:19Z

www/app/app.component.ts

+    if (value.match(/^inspec exec\s*examples\/profile\/controls\/example.rb\s*/)) {
+      this.getResponse(value, "inspec_exec");
+    }
+    else if (value.match(/^inspec exec\s*.*/)) {


We might want to find a way to parameterize responses so that we could capture the path here and inject it into the response we print.

vjeffrey · 2016-08-28T00:02:32Z

i'm working on a refactor commit that will pull the terminal view into its own component to make real shell emulation easier-- up arrow thru previous commands, prompt -command-repeat cycle -- and it will also reduce the amount of get requests.

chris-rock · 2016-08-29T09:56:48Z

@Vj you probably want to use https://github.com/drudru/ansi_up, this helps with the colors @stevendanna mentioned

chris-rock · 2016-08-29T10:01:51Z

Maybe https://github.com/sourcelair/xterm.js also helps with the rendering of a terminal

chris-rock · 2016-08-29T10:03:43Z

www/app/app.component.ts

+  }
+
+  evalInput(value) {
+    if (value.match(/^inspec exec\s*examples\/profile\s*/)) {


During generation of the commands, we probably want to have json file that tracks the commands. We could use https://github.com/chef/inspec/blob/master/tasks/command_simulator.rb#L4 as an external json. This enables us to use it as a reference in this app and as a list of commands for the rake task

chris-rock · 2016-08-29T10:06:07Z

This is a really great start @vjeffrey ! I see two points that we can improve:

create a json for all the commands, so that we can generate those (enables us to change only one file and use it for generation and web service )
improve rendering of the terminal e.g. reuse a term library available

chris-rock · 2016-08-29T10:07:53Z

Maybe we should move this to www/tutorial directory. this allows us to use the root www dir for the general app.

vjeffrey · 2016-08-29T12:48:24Z

just pushed up a commit i had started on friday to cleanup and refactor a bit/reduce get requests. also moved to tutorial folder. now i'm starting to work on getting xterm in, then once that's done i'll focus on command generating (json) and then the ui bits of making it look nice and ansi_up and stuffs

vjeffrey · 2016-08-31T17:37:42Z

@chris-rock @arlimus updated with the refactor/addressing comments. i still need to figure out the print a block of text and don't make it look crazy thing....working on it...
something else seems to have gone haywire as well - i deleted my node_modules and re-did npm install and all that and now it's saying Terminal isn't defined -- i'm looking into it

vjeffrey · 2016-09-01T02:09:57Z

holybergeeeeeez it took me forever to figure out everything was broken because xterm.js had some updates in the couple days. thus the pinning to 1.1.2 commit.

vjeffrey · 2016-09-01T13:25:21Z

@chris-rock @arlimus try it out I fixed things with @stevendanna's help :) :) :)

stevendanna · 2016-09-01T13:45:08Z

www/tutorial/app/responses/help.txt

@@ -0,0 +1,20 @@
+Commands:


A note on this: The problem we found is that the xterm js library expect windows style line endings \r\n. The rake task now generates files with the correct endings, but we may need to be vigilant to ensure that git doesn't mangle them.

chris-rock · 2016-09-01T14:58:46Z

Very nice first iteration @vjeffrey

vjeffrey · 2016-09-01T15:19:41Z

just pushed up another small commit -- realized i wasn't handling next and prev very well

chef-supermarket added the Signed CLA label Aug 26, 2016

vjeffrey force-pushed the vj/inspec-demo branch from 13f0744 to f3c85ba Compare August 26, 2016 16:17

chef-supermarket added the Signed CLA label Aug 26, 2016

stevendanna reviewed Aug 26, 2016
View reviewed changes

chef-supermarket added the Signed CLA label Aug 26, 2016

vjeffrey force-pushed the vj/inspec-demo branch from e8d0e27 to 8b24638 Compare August 26, 2016 22:08

chef-supermarket added the Signed CLA label Aug 26, 2016

chris-rock reviewed Aug 29, 2016
View reviewed changes

vjeffrey force-pushed the vj/inspec-demo branch from 735e462 to 38b2829 Compare August 29, 2016 12:46

chef-supermarket added the Signed CLA label Aug 29, 2016

vjeffrey force-pushed the vj/inspec-demo branch from f0c8c70 to 6b64e0e Compare August 29, 2016 23:48

chef-supermarket added the Signed CLA label Aug 29, 2016

vjeffrey force-pushed the vj/inspec-demo branch from 6b64e0e to 6d37405 Compare August 30, 2016 00:17

chef-supermarket added the Signed CLA label Aug 30, 2016

vjeffrey force-pushed the vj/inspec-demo branch from 6d37405 to 08b9d7d Compare August 30, 2016 00:21

chef-supermarket added the Signed CLA label Aug 30, 2016

vjeffrey force-pushed the vj/inspec-demo branch from 08b9d7d to d78740c Compare August 30, 2016 00:24

chef-supermarket added the Signed CLA label Aug 30, 2016