Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future Ohai: Remove legacy data in the Virtualization plugin #1126

Open
tas50 opened this issue Jan 30, 2018 · 2 comments
Open

Future Ohai: Remove legacy data in the Virtualization plugin #1126

tas50 opened this issue Jan 30, 2018 · 2 comments

Comments

@tas50
Copy link
Contributor

tas50 commented Jan 30, 2018

Before we introduced node['virtualization']['systems'] we used node['virtualization']['system'] and node['virtualization']['role']. This only allowed for a single virtualization, but we detected multiple technologies so the last writer won. We introduced the systems array in Chef 11 (pretty sure) which provides a much more reliable way to detect virtualization systems. We should create a Foodcritic rule and move people to the new system so we can fully deprecate the less than ideal older interface.

Scenario where the old interfaces fail:

virtualization
    systems
        kvm: host
        vmware: host
    system: vmware
    role: guest
@tas50 tas50 changed the title Chef 15: Remove legacy data in the Virtualization plugin Chef 16: Remove legacy data in the Virtualization plugin Nov 23, 2018
@btm
Copy link
Contributor

btm commented Mar 30, 2020

@tas50 is there a cookstyle rule for this?

@tas50
Copy link
Contributor Author

tas50 commented Mar 30, 2020

There is not. We probably need to have a rule in place for a while before we can consider removing anything.

@tas50 tas50 changed the title Chef 16: Remove legacy data in the Virtualization plugin Future Ohai: Remove legacy data in the Virtualization plugin Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants